Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-3810] Models for one time persona/accounts authentication #228

Merged
merged 20 commits into from
Oct 9, 2024
Merged

[ABW-3810] Models for one time persona/accounts authentication #228

merged 20 commits into from
Oct 9, 2024

Conversation

matiasbzurovski
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.1%. Comparing base (23d99bd) to head (dc605e2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #228   +/-   ##
=====================================
  Coverage   97.1%   97.1%           
=====================================
  Files        945     949    +4     
  Lines      14965   15010   +45     
  Branches      70      70           
=====================================
+ Hits       14535   14580   +45     
  Misses       420     420           
  Partials      10      10
Flag Coverage Δ
kotlin 98.5% <ø> (ø)
rust 96.5% <100.0%> (+<0.1%) ⬆️
swift 99.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...raction_items/request/entity/proof_of_ownership.rs 100.0% <100.0%> (ø)
.../interaction_items/request/unauthorized_request.rs 100.0% <100.0%> (ø)
...tion/wallet_to_dapp/failure_response/error_type.rs 100.0% <ø> (ø)
...let_to_dapp/success_response/authorized_request.rs 100.0% <ø> (ø)
..._to_dapp/success_response/persona/persona_proof.rs 100.0% <100.0%> (ø)
..._dapp/success_response/proof_of_ownership/proof.rs 100.0% <100.0%> (ø)
..._response/proof_of_ownership/proof_of_ownership.rs 100.0% <100.0%> (ø)
...t_to_dapp/success_response/unauthorized_request.rs 100.0% <100.0%> (ø)
crates/sargon/tests/vectors/main.rs 100.0% <ø> (ø)

giannis-rdx
giannis-rdx approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@giannis-rdx giannis-rdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@matiasbzurovski matiasbzurovski mentioned this pull request Oct 3, 2024
Merged
@matiasbzurovski matiasbzurovski merged commit a13a923 into main Oct 9, 2024
11 of 12 checks passed
@matiasbzurovski matiasbzurovski deleted the ABW-3810-one-time-authentication branch October 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giannis-rdx giannis-rdx giannis-rdx approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiasbzurovski @GhenadieVP @giannis-rdx